[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221226155029.244355-2-mcanal@igalia.com>
Date: Mon, 26 Dec 2022 12:50:21 -0300
From: Maíra Canal <mcanal@...lia.com>
To: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: Melissa Wen <mwen@...lia.com>,
André Almeida <andrealmeid@...lia.com>,
Lucas Stach <l.stach@...gutronix.de>,
Russell King <linux+etnaviv@...linux.org.uk>,
Christian Gmeiner <christian.gmeiner@...il.com>,
etnaviv@...ts.freedesktop.org, noralf@...nnes.org,
Liviu Dudau <liviu.dudau@....com>,
Brian Starkey <brian.starkey@....com>,
Emma Anholt <emma@...olt.net>,
Alexey Brodkin <abrodkin@...opsys.com>,
David Airlie <airlied@...hat.com>,
Gerd Hoffmann <kraxel@...hat.com>,
Gurchetan Singh <gurchetansingh@...omium.org>,
Chia-I Wu <olvaffe@...il.com>,
Tomi Valkeinen <tomba@...nel.org>,
Maíra Canal <mcanal@...lia.com>
Subject: [PATCH 1/9] drm/etnaviv: use new debugfs device-centered functions
Replace the use of drm_debugfs_create_files() with the new
drm_debugfs_add_files() function, which center the debugfs files
management on the drm_device instead of drm_minor. Moreover, remove the
debugfs_init hook and add the debugfs files directly on etnaviv_bind(),
before drm_dev_register().
Signed-off-by: Maíra Canal <mcanal@...lia.com>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 29 +++++++++++----------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 1d2b4fb4bcf8..2b265460672e 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -191,22 +191,22 @@ static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
static int show_unlocked(struct seq_file *m, void *arg)
{
- struct drm_info_node *node = (struct drm_info_node *) m->private;
- struct drm_device *dev = node->minor->dev;
+ struct drm_debugfs_entry *entry = m->private;
+ struct drm_device *dev = entry->dev;
int (*show)(struct drm_device *dev, struct seq_file *m) =
- node->info_ent->data;
+ entry->file.data;
return show(dev, m);
}
static int show_each_gpu(struct seq_file *m, void *arg)
{
- struct drm_info_node *node = (struct drm_info_node *) m->private;
- struct drm_device *dev = node->minor->dev;
+ struct drm_debugfs_entry *entry = m->private;
+ struct drm_device *dev = entry->dev;
struct etnaviv_drm_private *priv = dev->dev_private;
struct etnaviv_gpu *gpu;
int (*show)(struct etnaviv_gpu *gpu, struct seq_file *m) =
- node->info_ent->data;
+ entry->file.data;
unsigned int i;
int ret = 0;
@@ -223,20 +223,13 @@ static int show_each_gpu(struct seq_file *m, void *arg)
return ret;
}
-static struct drm_info_list etnaviv_debugfs_list[] = {
+static struct drm_debugfs_info etnaviv_debugfs_list[] = {
{"gpu", show_each_gpu, 0, etnaviv_gpu_debugfs},
{"gem", show_unlocked, 0, etnaviv_gem_show},
{ "mm", show_unlocked, 0, etnaviv_mm_show },
{"mmu", show_each_gpu, 0, etnaviv_mmu_show},
{"ring", show_each_gpu, 0, etnaviv_ring_show},
};
-
-static void etnaviv_debugfs_init(struct drm_minor *minor)
-{
- drm_debugfs_create_files(etnaviv_debugfs_list,
- ARRAY_SIZE(etnaviv_debugfs_list),
- minor->debugfs_root, minor);
-}
#endif
/*
@@ -478,9 +471,6 @@ static const struct drm_driver etnaviv_drm_driver = {
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
.gem_prime_mmap = drm_gem_prime_mmap,
-#ifdef CONFIG_DEBUG_FS
- .debugfs_init = etnaviv_debugfs_init,
-#endif
.ioctls = etnaviv_ioctls,
.num_ioctls = DRM_ETNAVIV_NUM_IOCTLS,
.fops = &fops,
@@ -534,6 +524,11 @@ static int etnaviv_bind(struct device *dev)
load_gpu(drm);
+#ifdef CONFIG_DEBUG_FS
+ drm_debugfs_add_files(drm, etnaviv_debugfs_list,
+ ARRAY_SIZE(etnaviv_debugfs_list));
+#endif
+
ret = drm_dev_register(drm, 0);
if (ret)
goto out_unbind;
--
2.38.1
Powered by blists - more mailing lists