linux-kernel - Re: [PATCH] kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221226173816.ii5hf3zt3pg52ww2@ldmartin-desk2.lan>
Date:   Mon, 26 Dec 2022 09:38:16 -0800
From:   Lucas De Marchi <lucas.de.marchi@...il.com>
To:     Florian Weimer <fweimer@...hat.com>
Cc:     linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmod: configure.ac: In _Noreturn check, include
 <stdlib.h> for exit

On Sat, Dec 17, 2022 at 05:52:34PM +0100, Florian Weimer wrote:
>Otherwise, an implicit functiona declaration is used, causing
>a C99 compatibility issue.
>
>Signed-off-by: Florian Weimer <fweimer@...hat.com>

applied, thanks

Lucas De Marchi

>
>---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 6989e93..12e0518 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(
>
> AC_MSG_CHECKING([whether _Noreturn is supported])
> AC_COMPILE_IFELSE(
>-	[AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
>+	[AC_LANG_SOURCE([[#include <stdlib.h>
>+	_Noreturn int foo(void) { exit(0); }]])],
>         [AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
> 	 AC_MSG_RESULT([yes])],
> 	[AC_MSG_RESULT([no])])
>
>base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602
>