linux-kernel - Re: [PATCH] block, bfq: fix uaf for bfqq in bfq_exit_icq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167208188642.23141.13167280199462782271.b4-ty@kernel.dk>
Date:   Mon, 26 Dec 2022 12:11:26 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     paolo.valente@...aro.org, jack@...e.cz,
        Yu Kuai <yukuai1@...weicloud.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq


On Mon, 26 Dec 2022 11:06:05 +0800, Yu Kuai wrote:
> Commit 64dc8c732f5c ("block, bfq: fix possible uaf for 'bfqq->bic'")
> will access 'bic->bfqq' in bic_set_bfqq(), however, bfq_exit_icq_bfqq()
> can free bfqq first, and then call bic_set_bfqq(), which will cause uaf.
> 
> Fix the problem by moving bfq_exit_bfqq() behind bic_set_bfqq().
> 
> 
> [...]

Applied, thanks!

[1/1] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
      commit: 246cf66e300b76099b5dbd3fdd39e9a5dbc53f02

Best regards,
-- 
Jens Axboe