linux-kernel - [PATCH -next] HID: amd-sfh-hid: also depends on INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 26 Dec 2022 13:46:44 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jkosina@...e.cz>,
        Basavaraj Natikar <basavaraj.natikar@....com>,
        linux-input@...r.kernel.org
Subject: [PATCH -next] HID: amd-sfh-hid: also depends on INPUT

AMD_SFH_HUB selects HID, which depends on INPUT, but since 'select'
does not follow any dependency chains, AMD_SFH_HUB should also
depend on INPUT.

Fixes multiple kconfig warnings and 90+ build errors (samples):

WARNING: unmet direct dependencies detected for HID
  Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
  Selected by [y]:
  - AMD_SFH_HID [=y] && HID_SUPPORT [=y] && (X86_64 || COMPILE_TEST [=y]) && PCI [=y]
  Selected by [m]:
  - I2C_HID_CORE [=m] && HID_SUPPORT [=y]
  - USB_HID [=m] && HID_SUPPORT [=y] && USB [=y] && INPUT [=m]

WARNING: unmet direct dependencies detected for INPUT_VIVALDIFMAP
  Depends on [m]: INPUT [=m]
  Selected by [y]:
  - HID_VIVALDI [=y] && HID_SUPPORT [=y] && HID [=y]

WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
  Depends on [m]: INPUT [=m]
  Selected by [y]:

ERROR: modpost: "input_ff_create_memless" [drivers/hid/hid-logitech.ko] undefined!
ERROR: modpost: "input_ff_create_memless" [drivers/hid/hid-mf.ko] undefined!
ERROR: modpost: "input_ff_create_memless" [drivers/input/misc/gpio-vibra.ko] undefined!
ERROR: modpost: "input_ff_create_memless" [drivers/input/misc/regulator-haptic.ko] undefined!
riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0x77e): undefined reference to `input_event'
riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xac2): undefined reference to `input_allocate_device'
riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xba8): undefined reference to `input_free_device'
riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xf4c): undefined reference to `input_scancode_to_scalar'

Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Fixes: 7e41b2e9776d ("HID: force HID depending on INPUT")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: Jiri Kosina <jkosina@...e.cz>
Cc: Basavaraj Natikar <basavaraj.natikar@....com>
Cc: linux-input@...r.kernel.org
---
 drivers/hid/amd-sfh-hid/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -- a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig
--- a/drivers/hid/amd-sfh-hid/Kconfig
+++ b/drivers/hid/amd-sfh-hid/Kconfig
@@ -1,10 +1,11 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 menu "AMD SFH HID Support"
 	depends on X86_64 || COMPILE_TEST
-	depends on PCI
+	depends on PCI && INPUT

 config AMD_SFH_HID
 	tristate "AMD Sensor Fusion Hub"
+	depends on INPUT
 	select HID
 	help
 	  If you say yes to this option, support will be included for the