linux-kernel - Re: [PATCH v4 3/6] ksm: count all zero pages placed by KSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Dec 2022 15:19:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     yang.yang29@....com.cn, akpm@...ux-foundation.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        david@...hat.com, imbrenda@...ux.ibm.com, jiang.xuexin@....com.cn,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        ran.xiaokai@....com.cn, xu.xin.sc@...il.com, xu.xin16@....com.cn,
        yang.yang29@....com.cn
Subject: Re: [PATCH v4 3/6] ksm: count all zero pages placed by KSM

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.2-rc1 next-20221220]
[cannot apply to shuah-kselftest/next shuah-kselftest/fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/yang-yang29-zte-com-cn/ksm-abstract-the-function-try_to_get_old_rmap_item/20221226-100925
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/202212261004269680139%40zte.com.cn
patch subject: [PATCH v4 3/6] ksm: count all zero pages placed by KSM
config: x86_64-rhel-8.3-rust
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7a5bf9867fe97f03edb941924c803327a1c2facb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review yang-yang29-zte-com-cn/ksm-abstract-the-function-try_to_get_old_rmap_item/20221226-100925
        git checkout 7a5bf9867fe97f03edb941924c803327a1c2facb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/ksm.c:3238:9: warning: no previous prototype for function 'zero_pages_sharing_show' [-Wmissing-prototypes]
   ssize_t zero_pages_sharing_show(struct kobject *kobj,
           ^
   mm/ksm.c:3238:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   ssize_t zero_pages_sharing_show(struct kobject *kobj,
   ^
   static 
   1 warning generated.


vim +/zero_pages_sharing_show +3238 mm/ksm.c

  3237	
> 3238	ssize_t zero_pages_sharing_show(struct kobject *kobj,
  3239					struct kobj_attribute *attr, char *buf)
  3240	{
  3241		return sysfs_emit(buf, "%ld\n", ksm_zero_pages_sharing);
  3242	}
  3243	KSM_ATTR_RO(zero_pages_sharing);
  3244	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (167700 bytes)