[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <38352fbb-663f-71f7-b7ef-d539b98fc423@linaro.org>
Date: Tue, 27 Dec 2022 09:21:49 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Souradeep Chowdhury <quic_schowdhu@...cinc.com>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>, Alex Elder <elder@...e.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
Sai Prakash Ranjan <quic_saipraka@...cinc.com>,
Sibi Sankar <quic_sibis@...cinc.com>,
Rajendra Nayak <quic_rjendra@...cinc.com>, vkoul@...nel.org
Subject: Re: [PATCH V20 1/7] dt-bindings: Added the yaml bindings for DCC
On 26/12/2022 17:52, Souradeep Chowdhury wrote:
> Documentation for Data Capture and Compare(DCC) device tree bindings
> in yaml format.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Subject: drop second, redundant "bindings". Drop "yaml" (also unrelated).
Use proper imperative mode.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,dcc.yaml | 44 ++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
> new file mode 100644
> index 0000000..ac3b51b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,dcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Data Capture and Compare
> +
> +maintainers:
> + - Souradeep Chowdhury <quic_schowdhu@...cinc.com>
> +
> +description: |
> + DCC (Data Capture and Compare) is a DMA engine which is used to save
> + configuration data or system memory contents during catastrophic failure
> + or SW trigger. DCC is used to capture and store data for debugging purpose
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,sm8150-dcc
> + - qcom,sc7280-dcc
> + - qcom,sc7180-dcc
> + - qcom,sdm845-dcc
> + - const: qcom,dcc
> +
> + reg:
> + items:
> + - description: DCC base
> + - description: DCC RAM base
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dma@...2000{
> + compatible = "qcom,sm8150-dcc","qcom,dcc";
Missing space between compatibles.
Best regards,
Krzysztof
Powered by blists - more mailing lists