[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y6qu/MeTAwqZURDg@black.fi.intel.com>
Date: Tue, 27 Dec 2022 10:38:20 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-kernel@...r.kernel.org, Martin Liska <mliska@...e.cz>,
Andreas Noever <andreas.noever@...il.com>,
Michael Jamet <michael.jamet@...el.com>,
Yehezkel Bernat <YehezkelShB@...il.com>,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] thunderbolt (gcc13): synchronize
tb_port_is_clx_enabled()'s 2nd param
On Mon, Dec 12, 2022 at 11:29:36AM +0100, Jiri Slaby (SUSE) wrote:
> tb_port_is_clx_enabled() generates a valid warning with gcc-13:
> drivers/thunderbolt/switch.c:1286:6: error: conflicting types for 'tb_port_is_clx_enabled' due to enum/integer mismatch; have 'bool(struct tb_port *, unsigned int)' ...
> drivers/thunderbolt/tb.h:1050:6: note: previous declaration of 'tb_port_is_clx_enabled' with type 'bool(struct tb_port *, enum tb_clx)' ...
>
> I.e. the type of the 2nd parameter of tb_port_is_clx_enabled() in the
> declaration is unsigned int, while the definition spells enum tb_clx.
> Synchronize them to the former as the parameter is in fact a mask of the
> enum values.
>
> Cc: Martin Liska <mliska@...e.cz>
> Cc: Andreas Noever <andreas.noever@...il.com>
> Cc: Michael Jamet <michael.jamet@...el.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Yehezkel Bernat <YehezkelShB@...il.com>
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
Applied now, thanks!
I changed the title slightly to avoid words like "synchronize" because
that makes me think this is fixing a race condition somewhere but in
fact this is simply fixing a function prototope to match the definition :)
Powered by blists - more mailing lists