linux-kernel - Re: [PATCH] remoteproc: qcom: pas: Fix subdevice add order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ead97313-c147-ae8b-dda6-c872475a9dd5@quicinc.com>
Date:   Tue, 27 Dec 2022 14:26:12 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <mathieu.poirier@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] remoteproc: qcom: pas: Fix subdevice add order

Hi,

Friendly reminder for review.

-Mukesh

On 12/14/2022 7:06 PM, Mukesh Ojha wrote:
> Currently, the notification like QCOM_SSR_BEFORE_SHUTDOWN is not exactly
> sent before starting shutdown activity on remote subsystem but it is
> getting sent after sysmon shutdown request to remote.
> 
> On getting QCOM_SSR_BEFORE_SHUTDOWN, some client want remote subsystem
> to be alive to communicate but as sysmon shutdown request is getting
> sent to remote before QCOM_SSR_BEFORE_SHUTDOWN notification sent to
> kernel client due to which remote is not in a condition to communicate
> with kernel clients.
> 
> Fixing the subdevice ordering will fix this as ssr subdevice will be
> first one to get triggered in shutdown/stop path.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@...cinc.com>
> ---
>   drivers/remoteproc/qcom_q6v5_pas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 6afd094..5e34d59 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -538,7 +538,6 @@ static int adsp_probe(struct platform_device *pdev)
>   
>   	qcom_add_glink_subdev(rproc, &adsp->glink_subdev, desc->ssr_name);
>   	qcom_add_smd_subdev(rproc, &adsp->smd_subdev);
> -	qcom_add_ssr_subdev(rproc, &adsp->ssr_subdev, desc->ssr_name);
>   	adsp->sysmon = qcom_add_sysmon_subdev(rproc,
>   					      desc->sysmon_name,
>   					      desc->ssctl_id);
> @@ -547,6 +546,7 @@ static int adsp_probe(struct platform_device *pdev)
>   		goto detach_proxy_pds;
>   	}
>   
> +	qcom_add_ssr_subdev(rproc, &adsp->ssr_subdev, desc->ssr_name);
>   	ret = rproc_add(rproc);
>   	if (ret)
>   		goto detach_proxy_pds;