linux-kernel - Re: [Patch V3] memory: tegra: Remove clients SID override programming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167213158105.15520.15913236649862406836.b4-ty@linaro.org>
Date:   Tue, 27 Dec 2022 09:59:40 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     dmitry.osipenko@...labora.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, jonathanh@...dia.com,
        Ashish Mhetre <amhetre@...dia.com>, thierry.reding@...il.com
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [Patch V3] memory: tegra: Remove clients SID override programming

On Fri, 25 Nov 2022 09:37:52 +0530, Ashish Mhetre wrote:
> On newer Tegra releases, early boot SID override programming and SID
> override programming during resume is handled by bootloader.
> In the function tegra186_mc_program_sid() which is getting removed, SID
> override register of all clients is written without checking if secure
> firmware has allowed write on it or not. If write is disabled by secure
> firmware then it can lead to errors coming from secure firmware and hang
> in kernel boot.
> Also, SID override is programmed on-demand during probe_finalize() call
> of IOMMU which is done in tegra186_mc_client_sid_override() in this same
> file. This function does it correctly by checking if write is permitted
> on SID override register. It also checks if SID override register is
> already written with correct value and skips re-writing it in that case.
> 
> [...]

Applied, thanks!

[1/1] memory: tegra: Remove clients SID override programming
      https://git.kernel.org/krzk/linux-mem-ctrl/c/ef86b2c2807f41c045e5534d8513a8b83f63bc39

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>