[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1848f28f-6c6e-4a1c-b58b-ccd52ae723f8@redhat.com>
Date: Tue, 27 Dec 2022 11:46:08 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
linux-kernel@...r.kernel.org
Cc: Ondrej Jirman <megi@....cz>, Robert Mader <robert.mader@...teo.de>,
Sam Ravnborg <sam@...nborg.org>,
Maya Matuszczyk <maccraft123mc@...il.com>,
Kamil TrzciĆski <ayufan@...fan.eu>,
Martijn Braam <martijn@...xit.nl>,
Peter Robinson <pbrobinson@...il.com>,
Tom Fitzhenry <tom@...-fitzhenry.me.uk>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel
controller
Hello Krzysztof,
On 12/27/22 08:44, Krzysztof Kozlowski wrote:
[...]
>> +required:
>> + - compatible
>> + - vcc-supply
>> + - iovcc-supply
>> + - port
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
Indeed. I did test in v1 but forgot to do it after addressing your
comments for v2. I have fixed the example snippet now and done it:
$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTEX Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dts
DTC_CHK Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dtb
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Powered by blists - more mailing lists