linux-kernel - Re: [PATCH 3/4] ARM: dts: qcom: sdx65: add specific compatible for USB HS PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542a4f6f-931a-3e0a-bd5d-1344339651ea@linaro.org>
Date:   Tue, 27 Dec 2022 12:14:30 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: qcom: sdx65: add specific compatible for
 USB HS PHY



On 24.12.2022 14:12, Krzysztof Kozlowski wrote:
> On 23/12/2022 17:20, Konrad Dybcio wrote:
>>
>>
>> On 23.12.2022 17:18, Krzysztof Kozlowski wrote:
>>> Add SoC-specific compatible to the USB HS PHY to match other devices and
>>> bindings.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>  arch/arm/boot/dts/qcom-sdx65.dtsi | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
>>> index b073e0c63df4..d3c661d7650d 100644
>>> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
>>> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
>>> @@ -219,7 +219,8 @@ blsp1_uart3: serial@...000 {
>>>  		};
>>>  
>>>  		usb_hsphy: phy@...000 {
>>> -			compatible = "qcom,usb-snps-hs-7nm-phy";
>>> +			compatible = "qcom,sdx65-usb-hs-phy",
>>> +				     "qcom,usb-snps-hs-7nm-phy";
>> Not sure if the newline is necessary, but still:
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> It is over 80 - up to 90 - and we still keep 80-limit in coding style.
Torvalds said 100 is fine a year a go or so.

Konrad
> 
> Best regards,
> Krzysztof
>