linux-kernel - Re: Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6rtS7AaQ+EmfD8o@sashalap>
Date:   Tue, 27 Dec 2022 08:04:11 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     stable-commits@...r.kernel.org, johan+linaro@...nel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added
 to the 5.15-stable tree

On Tue, Dec 27, 2022 at 10:14:59AM +0100, Johan Hovold wrote:
>On Sun, Dec 25, 2022 at 10:09:13AM -0500, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     phy: qcom-qmp-combo: fix runtime suspend
>>
>> to the 5.15-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      phy-qcom-qmp-combo-fix-runtime-suspend.patch
>> and it can be found in the queue-5.15 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@...r.kernel.org> know about it.
>>
>>
>>
>> commit d17b3a7b0119f7d92788acbe0f3d3b31bd8f892b
>> Author: Johan Hovold <johan+linaro@...nel.org>
>> Date:   Mon Nov 14 09:13:45 2022 +0100
>>
>>     phy: qcom-qmp-combo: fix runtime suspend
>>
>>     [ Upstream commit c7b98de745cffdceefc077ad5cf9cda032ef8959 ]
>>
>>     Drop the confused runtime-suspend type check which effectively broke
>>     runtime PM if the DP child node happens to be parsed before the USB
>>     child node during probe (e.g. due to order of child nodes in the
>>     devicetree).
>>
>>     Instead use the new driver data USB PHY pointer to access the USB
>>     configuration and resources.
>>
>>     Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
>>     Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>     Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
>>     Link: https://lore.kernel.org/r/20221114081346.5116-6-johan+linaro@kernel.org
>>     Signed-off-by: Vinod Koul <vkoul@...nel.org>
>>     Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This one was not marked for stable and can not be backported without
>further dependencies. This driver did not even exist in 5.15, and no,
>you should no try to backport the split of the original driver either.

I'll drop this patch.

>Sasha, please stop this madness.

So help me understand this... The fixes tag says:

	Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")

52e013d0bffa was merged in v5.10. Does the tag point to the wrong
commit?

-- 
Thanks,
Sasha