linux-kernel - Re: [PATCH v3 2/4] kernel/trace: Provide default impelentations defined in trace_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202212272221.pHKOYTSB-lkp@intel.com>
Date:   Tue, 27 Dec 2022 22:17:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Song Chen <chensong_2000@....cn>, rostedt@...dmis.org,
        mhiramat@...nel.org, arnd@...db.de
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        Song Chen <chensong_2000@....cn>
Subject: Re: [PATCH v3 2/4] kernel/trace: Provide default impelentations
 defined in trace_probe_tmpl.h

Hi Song,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arnd-asm-generic/master]
[also build test ERROR on linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Song-Chen/reorganize-trace_peobe_tmpl-h/20221206-205410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
patch link:    https://lore.kernel.org/r/1670228994-4020-1-git-send-email-chensong_2000%40189.cn
patch subject: [PATCH v3 2/4] kernel/trace: Provide default impelentations defined in trace_probe_tmpl.h
config: openrisc-randconfig-c44-20221225
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/baa4b7fb1f2e923d2d022bdc54f4d72f76aae41c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Song-Chen/reorganize-trace_peobe_tmpl-h/20221206-205410
        git checkout baa4b7fb1f2e923d2d022bdc54f4d72f76aae41c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/trace/trace_events_synth.c:22:
   kernel/trace/trace_probe_kernel.h: In function 'process_fetch_insn':
>> kernel/trace/trace_probe_kernel.h:204:23: error: implicit declaration of function 'regs_get_register'; did you mean 'kset_register'? [-Werror=implicit-function-declaration]
     204 |                 val = regs_get_register(regs, code->param);
         |                       ^~~~~~~~~~~~~~~~~
         |                       kset_register
>> kernel/trace/trace_probe_kernel.h:207:23: error: implicit declaration of function 'regs_get_kernel_stack_nth' [-Werror=implicit-function-declaration]
     207 |                 val = regs_get_kernel_stack_nth(regs, code->param);
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/trace/trace_probe_kernel.h:210:23: error: implicit declaration of function 'kernel_stack_pointer'; did you mean 'user_stack_pointer'? [-Werror=implicit-function-declaration]
     210 |                 val = kernel_stack_pointer(regs);
         |                       ^~~~~~~~~~~~~~~~~~~~
         |                       user_stack_pointer
   cc1: some warnings being treated as errors


vim +204 kernel/trace/trace_probe_kernel.h

   191	
   192	/* Note that we don't verify it, since the code does not come from user space */
   193	static int
   194	process_fetch_insn(struct fetch_insn *code, void *rec, void *dest,
   195			   void *base)
   196	{
   197		struct pt_regs *regs = rec;
   198		unsigned long val;
   199	
   200	retry:
   201		/* 1st stage: get value from context */
   202		switch (code->op) {
   203		case FETCH_OP_REG:
 > 204			val = regs_get_register(regs, code->param);
   205			break;
   206		case FETCH_OP_STACK:
 > 207			val = regs_get_kernel_stack_nth(regs, code->param);
   208			break;
   209		case FETCH_OP_STACKP:
 > 210			val = kernel_stack_pointer(regs);
   211			break;
   212		case FETCH_OP_RETVAL:
   213			val = regs_return_value(regs);
   214			break;
   215		case FETCH_OP_IMM:
   216			val = code->immediate;
   217			break;
   218		case FETCH_OP_COMM:
   219			val = (unsigned long)current->comm;
   220			break;
   221		case FETCH_OP_DATA:
   222			val = (unsigned long)code->data;
   223			break;
   224	#ifdef CONFIG_HAVE_FUNCTION_ARG_ACCESS_API
   225		case FETCH_OP_ARG:
   226			val = regs_get_kernel_argument(regs, code->param);
   227			break;
   228	#endif
   229		case FETCH_NOP_SYMBOL:	/* Ignore a place holder */
   230			code++;
   231			goto retry;
   232		case FETCH_OP_TP_ARG:
   233			val = get_event_field(code, rec);
   234			break;
   235		default:
   236			return -EILSEQ;
   237		}
   238		code++;
   239	
   240		return process_fetch_insn_bottom(code, val, dest, base);
   241	}
   242	NOKPROBE_SYMBOL(process_fetch_insn)
   243	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (205074 bytes)