linux-kernel - Re: [PATCH] arm64: dts: qcom: fix resin node duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221227171334.3zfesnmzbjc26sgz@SoMainline.org>
Date:   Tue, 27 Dec 2022 18:13:34 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Dzmitry Sankouski <dsankouski@...il.com>
Cc:     linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: fix resin node duplication

On 2022-12-27 19:38:10, Dzmitry Sankouski wrote:
> resin node was moved to pm8998.dtsi file, and introduced duplication
> with other dts files, defining resin node.

This is fixing the right thing for the wrong reasons.  As mentioned in
my report these nodes did not previously have status="okay" and ended up
disabled after your patch, which is much more important than a few
duplicate properties that were left in place.

Please resend with a commit message that carries this load.  The title
could/should contain something like "Re-enable resin on MSM8998 and
SDM845 boards".  After that you can add my:

Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>

> Fixes: f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit")
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>

You forgot to CC me, which would have happened automatically if you
added:

Reported-by: Marijn Suijten <marijn.suijten@...ainline.org> # https://lore.kernel.org/linux-arm-msm/20221222115922.jlachctn4lxopp7a@SoMainline.org/

Aside that, thanks a lot for caring about your patches and sending this
fixup!

- Marijn