linux-kernel - Re: [PATCH 2/2] scsi: ufs: ufs-qcom: Add hibernation callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212280548.ndaKckno-lkp@intel.com>
Date:   Wed, 28 Dec 2022 05:31:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anjana Hari <quic_ahari@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     oe-kbuild-all@...ts.linux.dev, alim.akhtar@...sung.com,
        avri.altman@....com, bvanassche@....org, konrad.dybcio@...aro.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_narepall@...cinc.com, quic_nitirawa@...cinc.com,
        quic_rampraka@...cinc.com, Anjana Hari <quic_ahari@...cinc.com>
Subject: Re: [PATCH 2/2] scsi: ufs: ufs-qcom: Add hibernation callbacks

Hi Anjana,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20221221171222.19699-3-quic_ahari%40quicinc.com
patch subject: [PATCH 2/2] scsi: ufs: ufs-qcom: Add hibernation callbacks
config: arm64-randconfig-c031-20221225
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6a52ff7dff6d455c578cd85689d6919b6866ad02
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
        git checkout 6a52ff7dff6d455c578cd85689d6919b6866ad02
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/ufs/host/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/ufs/host/ufs-qcom.c:1504:28: error: 'ufshcd_system_suspend' undeclared here (not in a function); did you mean 'ufshcd_runtime_suspend'?
    1504 |         .suspend         = ufshcd_system_suspend,
         |                            ^~~~~~~~~~~~~~~~~~~~~
         |                            ufshcd_runtime_suspend
>> drivers/ufs/host/ufs-qcom.c:1505:28: error: 'ufshcd_system_resume' undeclared here (not in a function); did you mean 'ufshcd_system_restore'?
    1505 |         .resume          = ufshcd_system_resume,
         |                            ^~~~~~~~~~~~~~~~~~~~
         |                            ufshcd_system_restore


vim +1504 drivers/ufs/host/ufs-qcom.c

  1499	
  1500	static const struct dev_pm_ops ufs_qcom_pm_ops = {
  1501		SET_RUNTIME_PM_OPS(ufshcd_runtime_suspend, ufshcd_runtime_resume, NULL)
  1502		.prepare	 = ufshcd_suspend_prepare,
  1503		.complete	 = ufshcd_resume_complete,
> 1504		.suspend         = ufshcd_system_suspend,
> 1505		.resume          = ufshcd_system_resume,
  1506		.freeze          = ufshcd_system_freeze,
  1507		.restore         = ufshcd_system_restore,
  1508		.thaw            = ufshcd_system_thaw,
  1509	};
  1510	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (169588 bytes)