[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221228075826.27396-1-miles.chen@mediatek.com>
Date: Wed, 28 Dec 2022 15:58:26 +0800
From: Miles Chen <miles.chen@...iatek.com>
To: <angelogioacchino.delregno@...labora.com>
CC: <chun-jie.chen@...iatek.com>, <daniel@...rotopia.org>,
<devicetree@...r.kernel.org>, <fparent@...libre.com>,
<ikjn@...omium.org>, <johnson.wang@...iatek.com>,
<jose.exposito89@...il.com>, <kernel@...labora.com>,
<krzysztof.kozlowski+dt@...aro.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>,
<miles.chen@...iatek.com>, <msp@...libre.com>,
<mturquette@...libre.com>, <nfraprado@...labora.com>,
<pablo.sun@...iatek.com>, <rex-bc.chen@...iatek.com>,
<robh+dt@...nel.org>, <ryder.lee@...nel.org>,
<sam.shih@...iatek.com>, <sboyd@...nel.org>,
<weiyi.lu@...iatek.com>, <wenst@...omium.org>,
<y.oudjana@...tonmail.com>, <yangyingliang@...wei.com>
Subject: Re: [PATCH v2 14/23] clk: mediatek: clk-mt8192: Move CLK_TOP_CSW_F26M_D2 in top_divs
> This driver is registered early in clk_mt8192_top_init_early() and
> then again in clk_mt8192_top_probe(): the difference between the
> two is that the early one is probed with CLK_OF_DECLARE_DRIVER and
> the latter is regularly probed as a platform_driver.
>
> Knowing that it is not necessary for this platform to register the
> TOP_CSW_F26M_D2 clock that early, move it to top_divs and register
> it with the others during platform_driver probe for topckgen;
>
> While at it, since the only reason why the early probe existed was
> to register that clock, remove that entirely - leaving this driver
> to use only platform_driver.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>
Thanks and this patch makes it easier to convert clk-mt8192 driver to a kernel module.
Reviewed-by: Miles Chen <miles.chen@...iatek.com>
Powered by blists - more mailing lists