linux-kernel - Re: [PATCH v3] device property: fix of node refcount leak in fwnode_graph_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6wQZOn+fObx0Mua@kroah.com>
Date:   Wed, 28 Dec 2022 10:46:12 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        djrscally@...il.com, heikki.krogerus@...ux.intel.com,
        sakari.ailus@...ux.intel.com, rafael@...nel.org
Subject: Re: [PATCH v3] device property: fix of node refcount leak in
 fwnode_graph_get_next_endpoint()

On Wed, Dec 28, 2022 at 11:37:15AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 23, 2022 at 10:25:42AM +0800, Yang Yingliang wrote:
> > The 'parent' returned by fwnode_graph_get_port_parent()
> > with refcount incremented when 'prev' is not NULL, it
> > needs be put when finish using it.
> > 
> > Because the parent is const, introduce a new variable to
> > store the returned fwnode, then put it before returning
> > from fwnode_graph_get_next_endpoint().
> 
> Rafael, Greg, is this went through the cracks?

Yes, but still in my queue.  I'll look at it when I get back from break.

thanks,

greg k-h