[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6waVkobLCGqRHm7@tp440p.steeds.sam>
Date: Wed, 28 Dec 2022 12:28:38 +0200
From: Sicelo <absicsz@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
tony@...mide.com, devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: n900: switch accelerometer to iio driver
Thank you for the review.
> > + lis302dl: lis302dl@1d {
>
> That's not really explained in commit msg and does not look related to
> your goal. If changing - in separate patch - make the node name generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Now I understand that it should just be `accelerometer@.... To be clear,
are you saying this change should have a separate patch, i.e. not part
of the switch to iio driver?
> > - Vdd-supply = <&vaux1>;
> > - Vdd_IO-supply = <&vio>;
> > + vdd-supply = <&vaux1>;
> > + vddio-supply = <&vio>;
>
> Does not look related/explained in commit msg.
This is from Documentation/devicetree/bindings/iio/st,st-sensors.yaml,
i.e. lowercase. I will look for a way to explain it in v2.
Sincerely
Sicelo
Powered by blists - more mailing lists