linux-kernel - Re: [PATCH] ARM: mm: fix warning on phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+G9fYvHyx+R2Dbw+qijK5aG=k2w+YN_o3-KwWVYK1U-3L-ddg@mail.gmail.com>
Date:   Wed, 28 Dec 2022 16:19:02 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Giulio Benetti <giulio.benetti@...ettiengineering.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Will Deacon <will@...nel.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH] ARM: mm: fix warning on phys_addr_t to void pointer assignment

On Wed, 14 Dec 2022 at 00:48, Giulio Benetti
<giulio.benetti@...ettiengineering.com> wrote:
>
> zero_page is a void* pointer but memblock_alloc() returns phys_addr_t type
> so this generates a warning while using clang and with -Wint-error enabled
> that becomes and error. So let's cast the return of memblock_alloc() to
> (void *).
>
> Cc: <stable@...r.kernel.org> # 4.14.x +
> Fixes: 340a982825f7 ("ARM: 9266/1: mm: fix no-MMU ZERO_PAGE() implementation")
> Signed-off-by: Giulio Benetti <giulio.benetti@...ettiengineering.com>

Tested-by: Linux Kernel Functional Testing <lkft@...aro.org>


> ---
>  arch/arm/mm/nommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index c1494a4dee25..53f2d8774fdb 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -161,7 +161,7 @@ void __init paging_init(const struct machine_desc *mdesc)
>         mpu_setup();
>
>         /* allocate the zero page. */
> -       zero_page = memblock_alloc(PAGE_SIZE, PAGE_SIZE);
> +       zero_page = (void *)memblock_alloc(PAGE_SIZE, PAGE_SIZE);
>         if (!zero_page)
>                 panic("%s: Failed to allocate %lu bytes align=0x%lx\n",
>                       __func__, PAGE_SIZE, PAGE_SIZE);
> --
> 2.34.1


--
Linaro LKFT
https://lkft.linaro.org