linux-kernel - Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6wlhfdDdm+XAsuH@matsya>
Date:   Wed, 28 Dec 2022 16:46:21 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Nicolas Frayer <nfrayer@...libre.com>
Cc:     peter.ujfalusi@...il.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, khilman@...libre.com,
        glaroque@...libre.com
Subject: Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when
 soc_device_match() returns NULL

On 17-11-22, 19:44, Nicolas Frayer wrote:
> When the k3 socinfo driver is built as a module, there is a possibility
> that it will probe after the k3 udma driver and the later returns -ENODEV.
> By deferring the k3 udma probe we allow the k3 socinfo to probe and
> register the soc_device_attribute structure needed by the k3 udma driver.
> Removed the dev_err() message as well as it's deferring and not failing.

lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX

> 
> Signed-off-by: Nicolas Frayer <nfrayer@...libre.com>
> ---
> v1->v2:
> Extracted this patch from the following series:
> https://lore.kernel.org/all/20221108181144.433087-1-nfrayer@baylibre.com/
> 
> v2->v3:
> Removed the dev_err() message
> 
>  drivers/dma/ti/k3-udma.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index ce8b80bb34d7..ca1512eb9910 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
>  	ud->match_data = match->data;
>  
>  	soc = soc_device_match(k3_soc_devices);
> -	if (!soc) {
> -		dev_err(dev, "No compatible SoC found\n");
> -		return -ENODEV;
> -	}
> +
> +	if (!soc)
> +		return -EPROBE_DEFER;
> +
>  	ud->soc_data = soc->data;
>  
>  	ret = udma_get_mmrs(pdev, ud);
> -- 
> 2.25.1

-- 
~Vinod