linux-kernel - Re: [PATCH v3 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7204e9a-cb23-c2ed-88de-0d6271bba98a@tom-fitzhenry.me.uk>
Date:   Thu, 29 Dec 2022 00:19:52 +1100
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Peter Robinson <pbrobinson@...il.com>,
        Martijn Braam <martijn@...xit.nl>,
        Maya Matuszczyk <maccraft123mc@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Neal Gompa <ngompa13@...il.com>,
        Kamil Trzciński <ayufan@...fan.eu>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Robert Mader <robert.mader@...teo.de>,
        Onuralp Sezer <thunderbirdtr@...oraproject.org>,
        Ondrej Jirman <megi@....cz>, dri-devel@...ts.freedesktop.org,
        Heiko Stuebner <heiko@...ech.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 4/4] arm64: dts: rk3399-pinephone-pro: Add internal
 display support

On 27/12/22 22:03, Javier Martinez Canillas wrote:
> From: Ondrej Jirman <megi@....cz>
> 
> The phone's display is using Hannstar LCD panel, and Goodix based
> touchscreen. Support it.
> 
> Signed-off-by: Ondrej Jirman <megi@....cz>
> Co-developed-by: Martijn Braam <martijn@...xit.nl>
> Signed-off-by: Martijn Braam <martijn@...xit.nl>
> Co-developed-by: Kamil Trzciński <ayufan@...fan.eu>
> Signed-off-by: Kamil Trzciński <ayufan@...fan.eu>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Tested-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>

Display and touchscreen works on my Pinephone Pro, thanks for the 
mainlining!

> @@ -367,6 +474,10 @@ vcc1v8_codec_en: vcc1v8-codec-en {
>   	};
>   };
>   
> +&pwm0 {
> +	status = "okay";
> +};

Please move &pwm0 before &sdio0, to keep this ~alphabetical.