linux-kernel - [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221228194249.170354-1-surenb@google.com>
Date:   Wed, 28 Dec 2022 11:42:49 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     akpm@...ux-foundation.org
Cc:     hughd@...gle.com, hannes@...xchg.org, david@...hat.com,
        vincent.whitchurch@...s.com, seanjc@...gle.com, rppt@...nel.org,
        shy828301@...il.com, pasha.tatashin@...een.com,
        paul.gortmaker@...driver.com, peterx@...hat.com, vbabka@...e.cz,
        Liam.Howlett@...cle.com, ccross@...gle.com, willy@...radead.org,
        arnd@...db.de, cgel.zte@...il.com, yuzhao@...gle.com,
        bagasdotme@...il.com, suleiman@...gle.com, steven@...uorix.net,
        heftig@...hlinux.org, cuigaosheng1@...wei.com,
        kirill@...temov.name, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        surenb@...gle.com,
        syzbot+91edf9178386a07d06a7@...kaller.appspotmail.com
Subject: [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs

free_anon_vma_name() is missing a check for anonymous shmem VMA which
leads to a memory leak due to refcount not being dropped. Fix this by
adding the missing check.

Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming")
Reported-by: syzbot+91edf9178386a07d06a7@...kaller.appspotmail.com
Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
---
 include/linux/mm_inline.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
index e8ed225d8f7c..d650ca2c5d29 100644
--- a/include/linux/mm_inline.h
+++ b/include/linux/mm_inline.h
@@ -413,7 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma)
 	 * Not using anon_vma_name because it generates a warning if mmap_lock
 	 * is not held, which might be the case here.
 	 */
-	if (!vma->vm_file)
+	if (!vma->vm_file || vma_is_anon_shmem(vma))
 		anon_vma_name_put(vma->anon_name);
 }
 
-- 
2.39.0.314.g84b9a713c41-goog