linux-kernel - Re: [PATCH 6.1 0000/1146] 6.1.2-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2022 13:31:23 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Díaz <daniel.diaz@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de
Subject: Re: [PATCH 6.1 0000/1146] 6.1.2-rc1 review

On Wed, Dec 28, 2022 at 03:15:01PM -0600, Daniel Díaz wrote:
> Hello!
> 
> 
> On 28/12/22 08:25, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.2 release.
> > There are 1146 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Fri, 30 Dec 2022 14:41:29 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.2-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> We're seeing the already reported problem with the unused variable 'rpm', but also seeing this on Arm, i386, MIPS, PA-RISC:
> 
I see this as well if I try to build with gcc 9.4, but not with gcc 11.3.
Interesting.

Anyway, the problem is fixed upstream with commit dd1f1da4ada5
("pwm: tegra: Fix 32 bit build").

Guenter

> | /builds/linux/drivers/pwm/pwm-tegra.c: In function 'tegra_pwm_config':
> | /builds/linux/drivers/pwm/pwm-tegra.c:148:53: error: result of '1000000000 << 8' requires 39 bits to represent, but 'long int' only has 32 bits [-Werror=shift-overflow=]
> |    required_clk_rate = DIV_ROUND_UP_ULL(NSEC_PER_SEC << PWM_DUTY_WIDTH,
> |                                                      ^~
> | /builds/linux/include/linux/math.h:40:32: note: in definition of macro 'DIV_ROUND_DOWN_ULL'
> |   ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; })
> |                                 ^~
> | /builds/linux/drivers/pwm/pwm-tegra.c:148:23: note: in expansion of macro 'DIV_ROUND_UP_ULL'
> |    required_clk_rate = DIV_ROUND_UP_ULL(NSEC_PER_SEC << PWM_DUTY_WIDTH,
> |                        ^~~~~~~~~~~~~~~~
> | cc1: all warnings being treated as errors
> 
> Those are with GCC-8 and allmodconfig.
> 
> Greetings!
> 
> Daniel Díaz
> daniel.diaz@...aro.org
>