linux-kernel - Re: [PATCH] bpf: Fix panic due to wrong pageattr of im->image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167226541519.8452.10536194221890799528.git-patchwork-notify@kernel.org>
Date:   Wed, 28 Dec 2022 22:10:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Chuang Wang <nashuiliang@...il.com>
Cc:     stable@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, kpsingh@...nel.org, sdf@...gle.com,
        haoluo@...gle.com, jolsa@...nel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Fix panic due to wrong pageattr of im->image

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Sat, 24 Dec 2022 21:31:46 +0800 you wrote:
> In the scenario where livepatch and kretfunc coexist, the pageattr of
> im->image is rox after arch_prepare_bpf_trampoline in
> bpf_trampoline_update, and then modify_fentry or register_fentry returns
> -EAGAIN from bpf_tramp_ftrace_ops_func, the BPF_TRAMP_F_ORIG_STACK flag
> will be configured, and arch_prepare_bpf_trampoline will be re-executed.
> 
> At this time, because the pageattr of im->image is rox,
> arch_prepare_bpf_trampoline will read and write im->image, which causes
> a fault. as follows:
> 
> [...]

Here is the summary with links:
  - bpf: Fix panic due to wrong pageattr of im->image
    https://git.kernel.org/bpf/bpf/c/9ed1d9aeef58

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html