[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221228231053.46fclmazl5qrjbmo@SoMainline.org>
Date: Thu, 29 Dec 2022 00:10:53 +0100
From: Marijn Suijten <marijn.suijten@...ainline.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Konrad Dybcio <konrad.dybcio@...aro.org>,
linux-arm-msm@...r.kernel.org, agross@...nel.org,
krzysztof.kozlowski@...aro.org, Rob Clark <robdclark@...il.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8150: Add DISPCC node
On 2022-12-27 22:16:58, Bjorn Andersson wrote:
> On Mon, Dec 12, 2022 at 10:33:13AM +0100, Konrad Dybcio wrote:
> > [..]
> > + power-domains = <&rpmhpd SM8150_MMCX>;
> > + /* TODO: Maybe rpmhpd_opp_min_svs could work as well? */
>
> The power-domain being not disabled should be sufficient for us to
> access the dispcc. Beyond that votes would be needed for particular
> frequencies, and that goes in the client nodes/opp-tables.
>
> So you should be able to drop this comment and the required-opps.
>
> Regards,
> Bjorn
>
> > + required-opps = <&rpmhpd_opp_low_svs>;
Tested the removal of this on Xperia 5, no regressions.
- Marijn
Powered by blists - more mailing lists