linux-kernel - Re: [PATCH v3 4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221228033259.vdajrkgxl5sy2ete@builder.lan>
Date:   Tue, 27 Dec 2022 21:32:59 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     swboyd@...omium.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
        mka@...omium.org, Yunlong Jia <ecs.beijing2022@...il.com>,
        linux-arm-msm@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-input@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: sc7180: Add pazquel360
 touschreen

On Fri, Dec 09, 2022 at 09:12:40AM -0800, Douglas Anderson wrote:
> The touchscreen was supposed to have been added when pazquel360 first
> was added upstream but was missed. Add it now.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> 
> Changes in v3:
> - Removed hid-descr-addr
> 
>  .../dts/qcom/sc7180-trogdor-pazquel360.dtsi   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> index 5702325d0c7b..ff9dd6857f8b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> @@ -14,6 +14,25 @@ &alc5682 {
>  	realtek,dmic-clk-rate-hz = <2048000>;
>  };
>  
> +ap_ts_pen_1v8: &i2c4 {
> +	status = "okay";

I'm told that we want status to be the last property, so I moved it
one step down as I applied the patch.

Thanks,
Bjorn

> +	clock-frequency = <400000>;
> +
> +	ap_ts: touchscreen@10 {
> +		compatible = "elan,ekth3915", "elan,ekth3500";
> +		reg = <0x10>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +
> +		vcc33-supply = <&pp3300_ts>;
> +		vccio-supply = <&pp1800_l10a>;
> +		reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> +	};
> +};
> +
>  &keyboard_controller {
>  	function-row-physmap = <
>  		MATRIX_KEY(0x00, 0x02, 0)	/* T1 */
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog
>