linux-kernel - Re: [PATCH v2] RDMA/srp (gcc13): move large values to a new enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167229780777.209797.11829150379699780577.b4-ty@kernel.org>
Date:   Thu, 29 Dec 2022 09:10:07 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     bvanassche@....org, "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc:     linux-rdma@...r.kernel.org, Jason Gunthorpe <jgg@...pe.ca>,
        Martin Liska <mliska@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] RDMA/srp (gcc13): move large values to a new enum

On Mon, 12 Dec 2022 13:04:11 +0100, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided these two:
>   SRP_TAG_NO_REQ        = ~0U,
>   SRP_TAG_TSK_MGMT	= 1U << 31
> all other members are unsigned ints.
> 
> Esp. with SRP_MAX_SGE and SRP_TSK_MGMT_SQ_SIZE and their use in min(),
> this results in the following warnings:
>   include/linux/minmax.h:20:35: error: comparison of distinct pointer types lacks a cast
>   drivers/infiniband/ulp/srp/ib_srp.c:563:42: note: in expansion of macro 'min'
> 
> [...]

Applied, thanks!

[1/1] RDMA/srp (gcc13): move large values to a new enum
      https://git.kernel.org/rdma/rdma/c/fb5b88f5b78192

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>