linux-kernel - Re: [PATCH] pinctrl: nomadik: fix build when DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y61aBzEjABMCXzmN@smile.fi.intel.com>
Date:   Thu, 29 Dec 2022 11:12:39 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] pinctrl: nomadik: fix build when DEBUG_FS is not set

On Wed, Dec 28, 2022 at 05:24:45PM -0800, Randy Dunlap wrote:
> Fix build when DEBUG_FS is not set/enabled by moving the #include
> directive.
> 
> ../drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> ../drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
>  1084 |         seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
> 
> Fixes: e5530adc17a7 ("pinctrl: Clean up headers")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>

I had sent
https://lore.kernel.org/linux-gpio/20221228084310.85210-1-andriy.shevchenko@linux.intel.com/T/#u
But now I see how I can amend it.

-- 
With Best Regards,
Andy Shevchenko