linux-kernel - Re: [PATCH v2] hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221228235933.GA417463@roeck-us.net>
Date:   Wed, 28 Dec 2022 16:05:03 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Derek John Clark <derekjohn.clark@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
        Joaquín Ignacio Aramendía <samsagax@...il.com>,
        linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro

On Wed, Dec 28, 2022 at 02:50:23PM -0800, Derek John Clark wrote:
> > > ---
> > >  Documentation/hwmon/oxp-sensors.rst | 19 ++++++----
> > >  MAINTAINERS                         |  1 +
> > >  drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
> > >  3 files changed, 59 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/Documentation/hwmon/oxp-sensors.rst b/Documentation/hwmon/oxp-sensors.rst
> > > index 39c588ec5c50..a53c961065b2 100644
> > > --- a/Documentation/hwmon/oxp-sensors.rst
> > > +++ b/Documentation/hwmon/oxp-sensors.rst
> > > @@ -3,18 +3,21 @@
> > >  Kernel driver oxp-sensors
> > >  =========================
> > >
> > > -Author:
> > > +Authors:
> > > +    - Derek John Clark <derekjohn.clark@...il.com>
> > >      - Joaquín Ignacio Aramendía <samsagax@...il.com>
> > >
> > > -Description:
> > > +Description
> > >  ------------
> >
> > Why drop ":" here ?
> To match the style of the rest of the Documentation section titles.
> Per Bagas Sanjaya previously:
> 
> >> -Author:
> >> +Authors:
> >> +    - Derek John Clark <derekjohn.clark@...il.com>
> >>      - Joaquín Ignacio Aramendía <samsagax@...il.com>
> >>
> >>  Description:
> >>  ------------
> 
> >Trim the trailing colon as it is not needed for section title.

That is POV, unrelated to this patch, and would have to be submitted as
separate patch. Please refrain from changes like that and get me involved
if someone requests it (actually they should provide such changes
themselves since they request it and it is unrelated, and they should
explain in the patch description why it is needed).

On a side note, '------------' would have to be changed as well.

Guenter

> 
> Additional changes forthcoming. Thanks.