linux-kernel - Re: [PATCH] mm/page_alloc.c: Remove function return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Dec 2022 20:34:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     lvqian@...china.com, akpm@...ux-foundation.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, lvqian <lvqian@...china.com>
Subject: Re: [PATCH] mm/page_alloc.c: Remove function return value

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/lvqian-nfschina-com/mm-page_alloc-c-Remove-function-return-value/20221229-152005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20221229071730.174444-1-lvqian%40nfschina.com
patch subject: [PATCH] mm/page_alloc.c: Remove function return value
config: arc-randconfig-r043-20221225
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1c571b39eb01c99e7832e61ccf5ab5e23ddf75d8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review lvqian-nfschina-com/mm-page_alloc-c-Remove-function-return-value/20221229-152005
        git checkout 1c571b39eb01c99e7832e61ccf5ab5e23ddf75d8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/printk.h:6,
                    from include/asm-generic/bug.h:22,
                    from arch/arc/include/asm/bug.h:30,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:6,
                    from mm/page_alloc.c:19:
>> mm/page_alloc.c:842:41: error: initialization of 'int (*)(char *)' from incompatible pointer type 'void (*)(char *)' [-Werror=incompatible-pointer-types]
     842 | early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/init.h:324:46: note: in definition of macro '__setup_param'
     324 |                 = { __setup_str_##unique_id, fn, early }
         |                                              ^~
   mm/page_alloc.c:842:1: note: in expansion of macro 'early_param'
     842 | early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
         | ^~~~~~~~~~~
   mm/page_alloc.c:842:41: note: (near initialization for '__setup_debug_guardpage_minorder_setup.setup_func')
     842 | early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/init.h:324:46: note: in definition of macro '__setup_param'
     324 |                 = { __setup_str_##unique_id, fn, early }
         |                                              ^~
   mm/page_alloc.c:842:1: note: in expansion of macro 'early_param'
     842 | early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
         | ^~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +842 mm/page_alloc.c

031bc5743f158b Joonsoo Kim       2014-12-12  830  
1c571b39eb01c9 lvqian            2022-12-29  831  static void __init debug_guardpage_minorder_setup(char *buf)
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  832  {
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  833  	unsigned long res;
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  834  
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  835  	if (kstrtoul(buf, 10, &res) < 0 ||  res > MAX_ORDER / 2) {
1170532bb49f94 Joe Perches       2016-03-17  836  		pr_err("Bad debug_guardpage_minorder value\n");
1c571b39eb01c9 lvqian            2022-12-29  837  	} else {
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  838  		_debug_guardpage_minorder = res;
1170532bb49f94 Joe Perches       2016-03-17  839  		pr_info("Setting debug_guardpage_minorder to %lu\n", res);
1c571b39eb01c9 lvqian            2022-12-29  840  	}
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  841  }
f1c1e9f7b5b3dd Joonsoo Kim       2016-10-07 @842  early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
c0a32fc5a2e470 Stanislaw Gruszka 2012-01-10  843  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (140688 bytes)