linux-kernel - Re: [PATCH v6 2/2] arm64: dts: mt8195: Add Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b4df04a2b99c3a09820608c3382f2ddc82e5eda.camel@mediatek.com>
Date:   Thu, 29 Dec 2022 02:46:00 +0000
From:   Biao Huang (黄彪) <Biao.Huang@...iatek.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        Macpaul Lin (林智斌) 
        <Macpaul.Lin@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v6 2/2] arm64: dts: mt8195: Add Ethernet controller

On Thu, 2022-12-29 at 02:06 +0100, Andrew Lunn wrote:
> > > Is the PHY integrated into the SoC, or on the board?
> > 
> > The PHY is on the board, an external device as to SoC.
> > > 
> > > You also don't need the compatible, if the PHY correctly
> > > implements
> > > the ID registers.
> > 
> > But without the compatible, it seems PHY driver will not be
> > attached.
> > How should I do? Thanks in advance.
> 
> Check what happens in mdiobus_scan() and get_phy_device(). When it
> reads registers 2 and 3, does it get valid ID register contents?
Yes, I tried remove the compatible, and PHY driver is attached as
expected. I'll remove the phy compatible in next send.
> 
>       Andrew
As to the "Confidentiality Notice", I have asked our IT to handle it.
Hope no such notice now.

Best Regards!
Biao