linux-kernel - Re: [PATCH v2 3/5] iio: pressure: bmp280: Add support for new sensor BMP580

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0e98b2d-1c00-b7cc-d0b3-4477e27cf822@wanadoo.fr>
Date:   Thu, 29 Dec 2022 18:35:29 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     ang.iglesiasg@...il.com
Cc:     ak@...klinger.de, andriy.shevchenko@...ux.intel.com,
        devicetree@...r.kernel.org, jic23@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lars@...afoo.de,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        nikita.yoush@...entembedded.com, paul@...pouillou.net,
        rafael.j.wysocki@...el.com, robh+dt@...nel.org,
        ulf.hansson@...aro.org
Subject: Re: [PATCH v2 3/5] iio: pressure: bmp280: Add support for new sensor
 BMP580

Le 26/12/2022 à 15:29, Angel Iglesias a écrit :
> Adds compatibility with the new sensor generation, the BMP580.
> 
> The measurement and initialization codepaths are adapted from
> the device datasheet and the repository from manufacturer at
> https://github.com/boschsensortec/BMP5-Sensor-API.
> 
> Signed-off-by: Angel Iglesias <ang.iglesiasg-Re5JQEeQqe8AvxtiuMwx3w@...lic.gmane.org>
> 

[...]

> diff --git a/drivers/iio/pressure/bmp280.h b/drivers/iio/pressure/bmp280.h
> index efc31bc84708..27d2abc17d01 100644
> --- a/drivers/iio/pressure/bmp280.h
> +++ b/drivers/iio/pressure/bmp280.h

[...]

> +#define BMP580_CHIP_ID			0x50
>   #define BMP380_CHIP_ID			0x50

Hi,

this is maybe correct (I've not been able to find the datasheet to check 
myself), but it looks odd to have the same ID for 2 different chips.

CJ

>   #define BMP180_CHIP_ID			0x55
>   #define BMP280_CHIP_ID			0x58