linux-kernel - Re: [PATCH] PCI: amlogic: The check for devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221229194333.GA625014@bhelgaas>
Date:   Thu, 29 Dec 2022 13:43:33 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Aleksandr Burakov <a.burakov@...alinux.ru>
Cc:     Yue Wang <yue.wang@...ogic.com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-pci@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] PCI: amlogic: The check for devm_add_action_or_reset's
 return value added

Hi Aleksandr,

Thanks for the patch!

On Tue, Dec 20, 2022 at 12:21:37PM +0300, Aleksandr Burakov wrote:
> The return value of the function devm_add_action_or_reset() was not
> checked hence an error code would not be returned.

You can save Lorenzo and Krzysztof some work by:

  - Rewording the subject line in the typical "<verb> <object>"
    imperative form, e.g., "Check for devm_add_action_or_reset()
    failure"

  - Rewording the commit log similarly.  Note that the existing commit
    only describes the current situation and doesn't actually say what
    the patch does.

Here's a good guide to commit logs: https://cbea.ms/git-commit/

> Fixes: 9c0ef6d34fdb ("PCI: amlogic: Add the Amlogic Meson PCIe controller driver")
> Signed-off-by: Aleksandr Burakov <a.burakov@...alinux.ru>
> ---
>  drivers/pci/controller/dwc/pci-meson.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index c1527693bed9..3d82f0b65480 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -187,9 +187,13 @@ static inline struct clk *meson_pcie_probe_clock(struct device *dev,
>  		return ERR_PTR(ret);
>  	}
>  
> -	devm_add_action_or_reset(dev,
> +	ret = devm_add_action_or_reset(dev,
>  				 (void (*) (void *))clk_disable_unprepare,
>  				 clk);
> +	if (ret) {
> +		dev_err(dev, "couldn't reset clk\n");
> +		return ERR_PTR(ret);
> +	}
>  
>  	return clk;
>  }
> -- 
> 2.25.1
>