linux-kernel - Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y637aBTrbRloUtvD@smile.fi.intel.com>
Date:   Thu, 29 Dec 2022 22:41:12 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tom Rix <trix@...hat.com>
Cc:     matthew.gerlach@...ux.intel.com, hao.wu@...el.com,
        yilun.xu@...el.com, russell.h.weight@...el.com,
        basheer.ahmed.muddebihal@...el.com, mdf@...nel.org,
        linux-fpga@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, tianfei.zhang@...el.com,
        corbet@....net, gregkh@...uxfoundation.org,
        linux-serial@...r.kernel.org, jirislaby@...nel.org,
        geert+renesas@...der.be, niklas.soderlund+renesas@...natech.se,
        macro@...am.me.uk, johan@...nel.org, lukas@...ner.de,
        ilpo.jarvinen@...ux.intel.com, marpagan@...hat.com,
        bagasdotme@...il.com
Subject: Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1

On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote:
> On 12/28/22 10:16 AM, matthew.gerlach@...ux.intel.com wrote:

...

> >   struct dfl_feature_info {
> >   	u16 fid;
> >   	u8 revision;
> > +	u8 dfh_version;
> >   	struct resource mmio_res;
> >   	void __iomem *ioaddr;
> >   	struct list_head node;
> >   	unsigned int irq_base;
> >   	unsigned int nr_irqs;
> > +	unsigned int param_size;
> > +	u64 params[];
> u64 *params

This will break the overflow.h macros, no?
Besides that it will break the code for sure as it's not an equivalent.

> >   };


-- 
With Best Regards,
Andy Shevchenko