linux-kernel - Re: [PATCH v2 5/8] objtool: reduce memory usage of struct reloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_61428759F197532A46AF38A338882C06D108@qq.com>
Date:   Thu, 29 Dec 2022 11:29:07 +0800
From:   Rong Tao <rtoax@...mail.com>
To:     thomas@...ch.de
Cc:     jpoimboe@...nel.org, linux-kernel@...r.kernel.org,
        linux@...ssschuh.net, peterz@...radead.org, rtoax@...mail.com,
        Rong Tao <rongtao@...tc.cn>
Subject: Re: [PATCH v2 5/8] objtool: reduce memory usage of struct reloc

Hi, Thomas:

In /usr/include/elf.h has:

#define ELF32_R_TYPE(val)		((val) & 0xff)
#define ELF64_R_TYPE(i)			((i) & 0xffffffff)
                                       ^^^^^^^^^^

So, I still feel that keeping 'unsigned int' is a good option. Can we just
use __attribute__((packed)) for wasted padding bytes?

Reviewed-by: Rong Tao <rongtao@...tc.cn>