lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212300642.6pdgegGO-lkp@intel.com>
Date:   Fri, 30 Dec 2022 07:00:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrzej Hajda <andrzej.hajda@...el.com>,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org, openrisc@...ts.librecores.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-xtensa@...ux-xtensa.org, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org
Cc:     oe-kbuild-all@...ts.linux.dev, Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg

Hi Andrzej,

I love your patch! Yet something to improve:

[auto build test ERROR on vgupta-arc/for-curr]
[also build test ERROR on arm64/for-next/core geert-m68k/for-next geert-m68k/for-linus deller-parisc/for-next powerpc/next powerpc/fixes s390/features linus/master v6.2-rc1 next-20221226]
[cannot apply to jcmvbkbc-xtensa/xtensa-for-next davem-sparc/master vgupta-arc/for-next openrisc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrzej-Hajda/arch-rename-all-internal-names-__xchg-to-__arch_xchg/20221229-193545
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git for-curr
patch link:    https://lore.kernel.org/r/20221229113338.2436892-1-andrzej.hajda%40intel.com
patch subject: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/977d2ba67f6de80971b7c2ea73430108e3db2177
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andrzej-Hajda/arch-rename-all-internal-names-__xchg-to-__arch_xchg/20221229-193545
        git checkout 977d2ba67f6de80971b7c2ea73430108e3db2177
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/alpha/include/asm/atomic.h:7,
                    from include/linux/atomic.h:7,
                    from include/linux/cpumask.h:13,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:63,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from kernel/events/core.c:11:
   kernel/events/core.c: In function '__perf_event_sync_stat':
>> arch/alpha/include/asm/cmpxchg.h:16:30: error: implicit declaration of function '__xchg_local'; did you mean 'xchg_local'? [-Werror=implicit-function-declaration]
      16 |         (__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,    \
         |                              ^~~~~~~~~~~~
   arch/alpha/include/asm/local.h:57:27: note: in expansion of macro 'xchg_local'
      57 | #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n)))
         |                           ^~~~~~~~~~
   include/asm-generic/local64.h:46:33: note: in expansion of macro 'local_xchg'
      46 | #define local64_xchg(l, n)      local_xchg((&(l)->a), (n))
         |                                 ^~~~~~~~~~
   kernel/events/core.c:3363:17: note: in expansion of macro 'local64_xchg'
    3363 |         value = local64_xchg(&event->count, value);
         |                 ^~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from arch/alpha/include/asm/atomic.h:7,
                    from include/linux/atomic.h:7,
                    from include/linux/rcupdate.h:25,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/ptrace.h:6,
                    from include/uapi/asm-generic/bpf_perf_event.h:4,
                    from ./arch/alpha/include/generated/uapi/asm/bpf_perf_event.h:1,
                    from include/uapi/linux/bpf_perf_event.h:11,
                    from include/linux/perf_event.h:18,
                    from kernel/events/ring_buffer.c:11:
   kernel/events/ring_buffer.c: In function '__perf_output_begin':
>> arch/alpha/include/asm/cmpxchg.h:16:30: error: implicit declaration of function '__xchg_local'; did you mean 'xchg_local'? [-Werror=implicit-function-declaration]
      16 |         (__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,    \
         |                              ^~~~~~~~~~~~
   arch/alpha/include/asm/local.h:57:27: note: in expansion of macro 'xchg_local'
      57 | #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n)))
         |                           ^~~~~~~~~~
   kernel/events/ring_buffer.c:247:42: note: in expansion of macro 'local_xchg'
     247 |                 lost_event.lost        = local_xchg(&rb->lost, 0);
         |                                          ^~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from arch/alpha/include/asm/atomic.h:7,
                    from include/linux/atomic.h:7,
                    from include/linux/rcupdate.h:25,
                    from include/linux/rbtree.h:24,
                    from include/linux/hrtimer.h:16,
                    from drivers/perf/arm-ccn.c:8:
   drivers/perf/arm-ccn.c: In function 'arm_ccn_pmu_event_update':
>> arch/alpha/include/asm/cmpxchg.h:16:30: error: implicit declaration of function '__xchg_local'; did you mean 'xchg_local'? [-Werror=implicit-function-declaration]
      16 |         (__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,    \
         |                              ^~~~~~~~~~~~
   arch/alpha/include/asm/local.h:57:27: note: in expansion of macro 'xchg_local'
      57 | #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n)))
         |                           ^~~~~~~~~~
   include/asm-generic/local64.h:46:33: note: in expansion of macro 'local_xchg'
      46 | #define local64_xchg(l, n)      local_xchg((&(l)->a), (n))
         |                                 ^~~~~~~~~~
   drivers/perf/arm-ccn.c:877:18: note: in expansion of macro 'local64_xchg'
     877 |         } while (local64_xchg(&hw->prev_count, new_count) != prev_count);
         |                  ^~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from arch/alpha/include/asm/atomic.h:7,
                    from include/linux/atomic.h:7,
                    from include/linux/cpumask.h:13,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/mutex.h:17,
                    from include/linux/kernfs.h:11,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/of.h:17,
                    from include/linux/irqdomain.h:35,
                    from include/linux/acpi.h:13,
                    from drivers/perf/arm-cmn.c:5:
   drivers/perf/arm-cmn.c: In function 'arm_cmn_event_read':
>> arch/alpha/include/asm/cmpxchg.h:16:30: error: implicit declaration of function '__xchg_local'; did you mean 'xchg_local'? [-Werror=implicit-function-declaration]
      16 |         (__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,    \
         |                              ^~~~~~~~~~~~
   arch/alpha/include/asm/local.h:57:27: note: in expansion of macro 'xchg_local'
      57 | #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n)))
         |                           ^~~~~~~~~~
   include/asm-generic/local64.h:46:33: note: in expansion of macro 'local_xchg'
      46 | #define local64_xchg(l, n)      local_xchg((&(l)->a), (n))
         |                                 ^~~~~~~~~~
   drivers/perf/arm-cmn.c:1299:16: note: in expansion of macro 'local64_xchg'
    1299 |         prev = local64_xchg(&event->hw.prev_count, new);
         |                ^~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from arch/alpha/include/asm/atomic.h:7,
                    from include/linux/atomic.h:7,
                    from include/linux/cpumask.h:13,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:63,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from arch/alpha/include/asm/io.h:8,
                    from include/linux/io.h:13,
                    from drivers/perf/marvell_cn10k_ddr_pmu.c:8:
   drivers/perf/marvell_cn10k_ddr_pmu.c: In function 'cn10k_ddr_perf_event_update':
>> arch/alpha/include/asm/cmpxchg.h:16:30: error: implicit declaration of function '__xchg_local'; did you mean 'xchg_local'? [-Werror=implicit-function-declaration]
      16 |         (__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,    \
         |                              ^~~~~~~~~~~~
   arch/alpha/include/asm/local.h:57:27: note: in expansion of macro 'xchg_local'
      57 | #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n)))
         |                           ^~~~~~~~~~
   include/asm-generic/local64.h:46:33: note: in expansion of macro 'local_xchg'
      46 | #define local64_xchg(l, n)      local_xchg((&(l)->a), (n))
         |                                 ^~~~~~~~~~
   drivers/perf/marvell_cn10k_ddr_pmu.c:415:18: note: in expansion of macro 'local64_xchg'
     415 |         } while (local64_xchg(&hwc->prev_count, new_count) != prev_count);
         |                  ^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +16 arch/alpha/include/asm/cmpxchg.h

5ba840f9da1ff9 Paul Gortmaker 2012-04-02  12  
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  13  #define xchg_local(ptr, x)						\
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  14  ({									\
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  15  	__typeof__(*(ptr)) _x_ = (x);					\
5ba840f9da1ff9 Paul Gortmaker 2012-04-02 @16  	(__typeof__(*(ptr))) __xchg_local((ptr), (unsigned long)_x_,	\
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  17  				       sizeof(*(ptr)));			\
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  18  })
5ba840f9da1ff9 Paul Gortmaker 2012-04-02  19  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (314385 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ