linux-kernel - [PATCH] of: overlay: fix warning being reported as error in add_changeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2022 08:40:50 +0000
From:   "Ankit 16. Kumar (Nokia)" <ankit.16.kumar@...ia.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] of: overlay: fix warning being reported as error in
 add_changeset_property


The print causes false reporting of the issue which actually is a warning
Fixes: 2fe0e8769df9 ("of: overlay: check prevents multiple fragments touching same property")

Signed-off-by: Ankit Kumar <ankit.16.kumar@...ia.com>
---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index ed4e6c144a68..0da39b8461e7 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, 
+property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {
--
2.30.1