linux-kernel - Re: [PATCH] mm: huge_memory: convert split_huge_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5166c14-ee1f-866d-4c11-8ac0417b78b1@huawei.com>
Date:   Fri, 30 Dec 2022 17:03:11 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a
 folio



On 2022/12/30 16:14, Matthew Wilcox wrote:
> On Thu, Dec 29, 2022 at 08:25:03PM +0800, Kefeng Wang wrote:
>> -			if (!PageHead(page) || PageHuge(page) || !PageLRU(page))
>> +			if (!folio_test_large(folio)
>> +				|| folio_test_hugetlb(folio)
>> +				|| !folio_test_lru(folio))
>>   				goto next;
> 
> That is a completely illegible way of indenting this code!  There's
> no visual cue when the condition stops and when the next statement
> begins.  Try one of these:
> 
sorry about the bad indenting,
> 			if (!folio_test_large(folio) ||
> 			    folio_test_hugetlb(folio) ||
> 			    !folio_test_lru(folio))
> 				goto next;
> 
will resend with this one, thanks for your review.