linux-kernel - Re: [PATCH] ARM: Remove redundant arch_cpu_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc13e5c0dba372ddb1435c959e7dc41f@linux.dev>
Date:   Fri, 30 Dec 2022 09:16:26 +0000
From:   "Yajun Deng" <yajun.deng@...ux.dev>
To:     rmk+kernel@...linux.org.uk, keescook@...omium.org,
        gregkh@...uxfoundation.org, Jason@...c4.com, djwong@...nel.org,
        ebiederm@...ssion.com, thunder.leizhen@...wei.com, ardb@...nel.org,
        wangkefeng.wang@...wei.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare()

December 1, 2022 11:13 AM, "Yajun Deng" <yajun.deng@...ux.dev> wrote:

> arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
> just a wrapper for local_fiq_enable().
> 
> The local_fiq_enable() was already called before cpu_startup_entry().
> 
> So remove redundant arch_cpu_idle_prepare().
> 
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
> arch/arm/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f811733a8fc5..e3f490ab95f4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -81,11 +81,6 @@ void arch_cpu_idle(void)
> raw_local_irq_enable();
> }
> 
> -void arch_cpu_idle_prepare(void)
> -{
> - local_fiq_enable();
> -}
> -
> void arch_cpu_idle_enter(void)
> {
> ledtrig_cpu(CPU_LED_IDLE_START);
> -- 
> 2.25.1

Ping.