linux-kernel - Re: [PATCH v1] exfat: fix unexpected EOF while reading dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9QLm29mR_FMhEriozHRczkx3A=9CmVWC1KOPGJDwhitQ@mail.gmail.com>
Date:   Fri, 30 Dec 2022 10:33:29 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
Cc:     "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andy.Wu@...y.com" <Andy.Wu@...y.com>,
        "Wataru.Aoyama@...y.com" <Wataru.Aoyama@...y.com>,
        Wang Yugui <wangyugui@...-tech.com>
Subject: Re: [PATCH v1] exfat: fix unexpected EOF while reading dir

2022-12-26 16:23 GMT+09:00, Yuezhang.Mo@...y.com <Yuezhang.Mo@...y.com>:
> If the position is not aligned with the dentry size, the return
> value of readdir() will be NULL and errno is 0, which means the
> end of the directory stream is reached.
>
> If the position is aligned with dentry size, but there is no file
> or directory at the position, exfat_readdir() will continue to
> get dentry from the next dentry. So the dentry gotten by readdir()
> may not be at the position.
>
> After this commit, if the position is not aligned with the dentry
> size, round the position up to the dentry size and continue to get
> the dentry.
>
> Fixes: ca06197382bd ("exfat: add directory operations")
>
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@...y.com>
> Reviewed-by: Andy Wu <Andy.Wu@...y.com>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@...y.com>
> Reported-by: Wang Yugui <wangyugui@...-tech.com>
Applied, Thanks for your patch!