linux-kernel - Re: [PATCH] gpiolib: use irq_domain_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mfp8HyQiUJdsNPQFHK0bosA1Qy=jvdmxOSVAzNo3AO_2w@mail.gmail.com>
Date:   Fri, 30 Dec 2022 11:08:30 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: use irq_domain_alloc_irqs()

On Tue, Dec 13, 2022 at 2:52 PM Johan Hovold <johan+linaro@...nel.org> wrote:
>
> Use the irq_domain_alloc_irqs() wrapper instead of the full
> __irq_domain_alloc_irqs() interface, which was only intended for some
> legacy (x86) use cases.
>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  drivers/gpio/gpiolib.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 5a66d9616d7c..ede9630b197c 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1126,14 +1126,8 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc,
>                         /* Just pick something */
>                         fwspec.param[1] = IRQ_TYPE_EDGE_RISING;
>                         fwspec.param_count = 2;
> -                       ret = __irq_domain_alloc_irqs(gc->irq.domain,
> -                                                     /* just pick something */
> -                                                     -1,
> -                                                     1,
> -                                                     NUMA_NO_NODE,
> -                                                     &fwspec,
> -                                                     false,
> -                                                     NULL);
> +                       ret = irq_domain_alloc_irqs(gc->irq.domain, 1,
> +                                                   NUMA_NO_NODE, &fwspec);
>                         if (ret < 0) {
>                                 chip_err(gc,
>                                          "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n",
> --
> 2.37.4
>

Applied, thanks!

Bart