linux-kernel - Re: [PATCH 0/3] fs/ntfs3: Fixes for big endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c45a3aa-275a-2815-79bf-ef72df30db97@paragon-software.com>
Date:   Fri, 30 Dec 2022 16:07:12 +0400
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Thomas Kühnel <thomas.kuehnel@....de>
CC:     <ntfs3@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] fs/ntfs3: Fixes for big endian systems

On 07.12.2021 14:24, Thomas Kühnel wrote:
> I tried running the NTFS3 driver on a MIPS big endian system and
> noticed various errors when it tried to access bitmaps structures
> that are stored as little endian on disk.
>
> These patches were mainly tested in a qemu mips environment.
>
> I'm open for suggestions how to better implement the second patch
> "add functions to modify LE bitmaps". It adds copies of two functions
> from lib/bitmap.c but modified to work with little endian bitmaps.
> Other filesystems seem to have similar functions defined locally like
> le_bitmap_set in btrfs or ext4_set_bits in ext4 but no global
> implementation exists.
>
> Thomas Kühnel (3):
>    fs/ntfs3: fix endian conversion in ni_fname_name
>    fs/ntfs3: add functions to modify LE bitmaps
>    fs/ntfs3: use _le variants of bitops functions
>
>   fs/ntfs3/bitmap.c  | 56 +++++++++++++++++++++++++++++++++++++++-------
>   fs/ntfs3/frecord.c |  4 +++-
>   fs/ntfs3/fslog.c   |  4 ++--
>   fs/ntfs3/fsntfs.c  |  8 +++----
>   fs/ntfs3/index.c   | 14 ++++++------
>   fs/ntfs3/ntfs_fs.h |  3 +++
>   6 files changed, 67 insertions(+), 22 deletions(-)
>
>
> base-commit: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1

Hello Thomas,

Thanks for patches, they have been applied long ago.

Sorry for not responding immediately.