linux-kernel - Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2022 13:50:20 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Tudor Ambarus <tudor.ambarus@...aro.org>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <pratyush@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Michael Walle <michael@...le.cc>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Takahiro Kuwano <Takahiro.Kuwano@...ineon.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@....com>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        Mauro Lima <mauro.lima@...ypsium.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone

Hi Tudor,

tudor.ambarus@...aro.org wrote on Mon, 26 Dec 2022 16:22:02 +0200:

> On 21.12.2022 08:49, Tudor Ambarus wrote:
> > 
> > 
> > On 20.12.2022 17:57, Miquel Raynal wrote:  
> >> Hi Tudor,
> >>  
> > 
> > Hi,
> >   
> >> tudor.ambarus@...aro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:
> >>  
> >>> Hi, Arnd,
> >>>
> >>> On 20.12.2022 16:13, Arnd Bergmann wrote:  
> >>>> From: Arnd Bergmann <arnd@...db.de>
> >>>>
> >>>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
> >>>> fails to build, as it includes the shared CFI header:
> >>>>
> >>>> include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix >>>> selected. No NOR chip support can work. [-Werror=cpp]
> >>>>      62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip >>>> support can work.
> >>>>
> >>>> linux/mtd/spi-nor.h does not actually need to include cfi.h, so
> >>>> remove the inclusion here to fix the warning. This uncovers a
> >>>> missing #include in spi-nor/core.c so add that there to
> >>>> prevent a different build issue.
> >>>>
> >>>> Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
> >>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>  
> >>>
> >>> Looks good to me. I'll let the linux-0day bot run over it and apply it
> >>> once -rc1 is out.  
> >>
> >> The issue sometimes produces build errors, shall I send it through a
> >> fixes PR instead?
> >>  
> > 
> > Yes, that I was thinking about.
> >   
> 
> Seems that I shouldn't push to mtd/fixes, so:
> Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>

Oh yes you can, sorry for the misunderstanding, but as I am often alone
to do it, I read your "I will apply" message last time and understood "I
will apply on spi-nor/next". 

You can update mtd/fixes to -rc1 and push the patch, as long as we keep
each other in sync ;)

Thanks!
Miquèl