linux-kernel - Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iNdLyOpAxsCTTq-zqRfWDrJ5_c2DUcJYE5ZFn7u+2qdQ@mail.gmail.com>
Date:   Fri, 30 Dec 2022 16:52:36 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Joel Fernandes <joel@...lfernandes.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        linux-acpi@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Brian Norris <briannorris@...omium.org>,
        Ross Zwisler <zwisler@...gle.com>,
        Ching-lin Yu <chinglinyu@...gle.com>
Subject: Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer

On Thu, Dec 15, 2022 at 9:13 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Thu, 15 Dec 2022 14:52:48 -0500
> Joel Fernandes <joel@...lfernandes.org> wrote:
>
> > Another approach could be to always enable the trace event by default,
> > if the CONFIG is turned on. Or do a printk() telling the user about
> > the event to enable, so they know why their trace buffer is empty.
>
> Yeah, that is another option.
>
> And, yes I need to document it better. I started to, but then decided to
> hold off until I get some feedback in case this is rejected.
>
> >
> > Up to you and the ACPI maintainers. ;-)
>
> I'm going to guess I may not hear back until the new year. I'm fine with
> that :-)

It's just a couple of days, but still.

Personally, I would use a command line option to control the behavior
and the Kconfig option to provide its default value.

This way it can be flipped without rebuilding the kernel if need be.

I would also make the ACPI debug output go into the trace buffer so
long as the Kconfig option is not changed or the command line option
is not flipped.

Cheers!