linux-kernel - Re: [PATCH v1 1/2] ACPI: Silence missing prototype warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2022 19:13:35 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ammar Faizi <ammarfaizi2@...weeb.org>
Cc:     Robert Moore <robert.moore@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Linux ACPI Mailing List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPICA Mailing List <devel@...ica.org>,
        LLVM Mailing List <llvm@...ts.linux.dev>,
        "GNU/Weeb Mailing List" <gwml@...r.gnuweeb.org>
Subject: Re: [PATCH v1 1/2] ACPI: Silence missing prototype warnings

On Fri, Dec 23, 2022 at 3:25 PM Ammar Faizi <ammarfaizi2@...weeb.org> wrote:
>
> From: Ammar Faizi <ammarfaizi2@...weeb.org>
>
> Compiling with clang-16:
>
>   drivers/acpi/acpi_lpit.c:142:6: error: no previous prototype \
>   for function 'acpi_init_lpit' [-Werror,-Wmissing-prototypes]
>
>   drivers/acpi/ioapic.c:212:6: error: no previous prototype \
>   for function 'pci_ioapic_remove' [-Werror,-Wmissing-prototypes]
>
>   drivers/acpi/ioapic.c:229:5: error: no previous prototype \
>   for function 'acpi_ioapic_remove' [-Werror,-Wmissing-prototypes]
>
> Include "internal.h" to silence them.
>
> Cc: LLVM Mailing List <llvm@...ts.linux.dev>
> Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org>
> ---
>  drivers/acpi/acpi_lpit.c | 1 +
>  drivers/acpi/ioapic.c    | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c
> index 50540d4d4948..3843d2576d3f 100644
> --- a/drivers/acpi/acpi_lpit.c
> +++ b/drivers/acpi/acpi_lpit.c
> @@ -10,6 +10,7 @@
>  #include <linux/acpi.h>
>  #include <asm/msr.h>
>  #include <asm/tsc.h>
> +#include "internal.h"
>
>  struct lpit_residency_info {
>         struct acpi_generic_address gaddr;
> diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
> index a690c7b18623..6677955b4a8e 100644
> --- a/drivers/acpi/ioapic.c
> +++ b/drivers/acpi/ioapic.c
> @@ -24,6 +24,7 @@
>  #include <linux/acpi.h>
>  #include <linux/pci.h>
>  #include <acpi/acpi.h>
> +#include "internal.h"
>
>  struct acpi_pci_ioapic {
>         acpi_handle     root_handle;
> --

Applied as 6.3 material, thanks!