linux-kernel - Re: [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y69Z6FhmypFASRyX@smile.fi.intel.com>
Date:   Fri, 30 Dec 2022 23:36:40 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Haibo Chen <haibo.chen@....com>
Subject: Re: [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value
 pinctrl

On Fri, Dec 30, 2022 at 01:48:20PM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 30, 2022 at 1:04 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Sun, Dec 11, 2022 at 12:05:58AM +0200, Andy Shevchenko wrote:
> > > From: Haibo Chen <haibo.chen@....com>
> > >
> > > There is a variable pinctrl declared without initializer. And then
> > > has the case (switch operation chose the default case) to directly
> > > use this uninitialized value, this is not a safe behavior. So here
> > > initialize the pinctrl as 0 to avoid this issue.
> > > This is reported by Coverity.
> >
> > Bart, any comments on the series?
> 
> Now applied. I just got back from Christmas break, give me a moment. :)

Sure and thank you! Merry xmas!

-- 
With Best Regards,
Andy Shevchenko