linux-kernel - Re: [PATCH] misc: hpilo: Fix use-after-free in ilo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7AhLWSPE+2hnZ2I@kroah.com>
Date:   Sat, 31 Dec 2022 12:46:53 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yoochan Lee <yoochan1026@...il.com>
Cc:     matt.hsiao@....com, arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: hpilo: Fix use-after-free in ilo_open

On Sat, Dec 31, 2022 at 07:05:36PM +0900, Yoochan Lee wrote:
> Hi,
> 
> I haven't tested with a physical device cause I don't have a real device.
> I found this bug through static analysis.

Then please verify that it actually is a bug and that you have fixed it
properly.  To send patches that are broken wastes everyone's time :(

Also, you did not properly describe how the static analysis happened or
what tools reported it as is required.

> This type of bug is similar to [1] and [2].
> 
> And I'm sorry that my patch is incorrect.
> It's my first time patching a Linux kernel myself.

I suggest taking the tutorial on kernelnewbies.org and working in the
drivers/staging/* portion of the kernel first, so that you can learn how
this all works.  Do not dive in and assume that fixing issues that a
random tool spits out is even correct to do.

good luck!

greg k-h