linux-kernel - Re: [PATCH v1 2/2] leds: add aw20xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 31 Dec 2022 23:44:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Martin Kurbanov <mmkurbanov@...rdevices.ru>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, kernel@...rdevices.ru,
        Martin Kurbanov <mmkurbanov@...rdevices.ru>
Subject: Re: [PATCH v1 2/2] leds: add aw20xx driver

Hi Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pavel-leds/for-next]
[also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Martin-Kurbanov/leds-add-aw20xx-driver/20221125-044946
base:   git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
patch link:    https://lore.kernel.org/r/20221124204807.1593241-3-mmkurbanov%40sberdevices.ru
patch subject: [PATCH v1 2/2] leds: add aw20xx driver
config: x86_64-randconfig-a013-20211213-CONFIG_RCU_TORTURE_TEST
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7dd31514a1ac86c2213320eef707cdaf0643ac6f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Martin-Kurbanov/leds-add-aw20xx-driver/20221125-044946
        git checkout 7dd31514a1ac86c2213320eef707cdaf0643ac6f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/leds/leds-aw200xx.c:1089:34: warning: 'aw200xx_match_table' defined but not used [-Wunused-const-variable=]
    1089 | static const struct of_device_id aw200xx_match_table[] = {
         |                                  ^~~~~~~~~~~~~~~~~~~


vim +/aw200xx_match_table +1089 drivers/leds/leds-aw200xx.c

  1088	
> 1089	static const struct of_device_id aw200xx_match_table[] = {
  1090		{ .compatible = "awinic,aw20036", .data = &aw20036_cdef, },
  1091		{ .compatible = "awinic,aw20054", .data = &aw20054_cdef, },
  1092		{ .compatible = "awinic,aw20072", .data = &aw20072_cdef, },
  1093		{},
  1094	};
  1095	MODULE_DEVICE_TABLE(of, aw200xx_match_table);
  1096	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (147634 bytes)