linux-kernel - Re: [PATCH 1/2] kbuild: change module.order to list *.o instead of *.ko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Dec 2022 18:47:45 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>, Tom Rix <trix@...hat.com>,
        linux-modules@...r.kernel.org, llvm@...ts.linux.dev,
        kernel@...gutronix.de
Subject: Re: [PATCH 1/2] kbuild: change module.order to list *.o instead of
 *.ko

On 11.12.2022 22:04:07, Masahiro Yamada wrote:
> scripts/Makefile.build replaces the suffix .o with .ko, then
> scripts/Makefile.modpost calls the sed command to change .ko back
> to the original .o suffix.
> 
> Instead of converting the suffixes back-and-forth, store the .o paths
> in modules.order, and replace it with .ko in 'make modules_install'.
> 
> This avoids the unneeded sed command.

This breaks direct compilation of kernel modules (on current Linus's
master):

| $ make drivers/net/can/dev/can-dev.ko
| [...]
|   CC [M]  drivers/net/can/dev/skb.o
|   CC [M]  drivers/net/can/dev/calc_bittiming.o
|   CC [M]  drivers/net/can/dev/bittiming.o
|   CC [M]  drivers/net/can/dev/dev.o
|   CC [M]  drivers/net/can/dev/length.o
|   CC [M]  drivers/net/can/dev/netlink.o
|   LD [M]  drivers/net/can/dev/can-dev.o
| make[5]: 'drivers/net/can/dev/can-dev.mod' is up to date.
|   LDS     scripts/module.lds
|   MODPOST Module.symvers
| drivers/net/can/dev/can-dev.ko: No such file or directory
| make[1]: *** [.../linux/scripts/Makefile.modpost:129: Module.symvers] Error 1
| make: *** [.../linux/Makefile:1982: single_modules] Error 2

According to "make help" it should be possible:

|  dir/file.ko     - Build module including final link

I've bisected it to:

| first bad commit: [f65a486821cfd363833079b2a7b0769250ee21c9] kbuild: change module.order to list *.o instead of *.ko

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)