linux-kernel - Re: [PATCH v2] drm: kirin: Enable COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Jan 2023 05:27:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Anderson <sean.anderson@...o.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Xinliang Liu <xinliang.liu@...aro.org>,
        Chen Feng <puck.chen@...ilicon.com>,
        linux-kernel@...r.kernel.org,
        Sean Anderson <sean.anderson@...o.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        John Stultz <jstultz@...gle.com>,
        Tian Tao <tiantao6@...ilicon.com>
Subject: Re: [PATCH v2] drm: kirin: Enable COMPILE_TEST

Hi Sean,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/drm-kirin-Enable-COMPILE_TEST/20221227-235347
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20221227155056.2271217-1-sean.anderson%40seco.com
patch subject: [PATCH v2] drm: kirin: Enable COMPILE_TEST
config: sparc-randconfig-c041-20230101
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/256e617c346efb5c169aafe538f8a7885baddd45
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sean-Anderson/drm-kirin-Enable-COMPILE_TEST/20221227-235347
        git checkout 256e617c346efb5c169aafe538f8a7885baddd45
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/gpu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c:30:
   drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h: In function 'dw_update_bits':
>> drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:93:16: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
      93 |         orig = readl(addr);
         |                ^~~~~
>> drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:96:9: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
      96 |         writel(tmp, addr);
         |         ^~~~~~
   cc1: some warnings being treated as errors


vim +/readl +93 drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h

f819b0d4a91344c Xinliang Liu 2015-11-23  84  
f819b0d4a91344c Xinliang Liu 2015-11-23  85  /*
f819b0d4a91344c Xinliang Liu 2015-11-23  86   * Register Write/Read Helper functions
f819b0d4a91344c Xinliang Liu 2015-11-23  87   */
f819b0d4a91344c Xinliang Liu 2015-11-23  88  static inline void dw_update_bits(void __iomem *addr, u32 bit_start,
f819b0d4a91344c Xinliang Liu 2015-11-23  89  				  u32 mask, u32 val)
f819b0d4a91344c Xinliang Liu 2015-11-23  90  {
f819b0d4a91344c Xinliang Liu 2015-11-23  91  	u32 tmp, orig;
f819b0d4a91344c Xinliang Liu 2015-11-23  92  
f819b0d4a91344c Xinliang Liu 2015-11-23 @93  	orig = readl(addr);
f819b0d4a91344c Xinliang Liu 2015-11-23  94  	tmp = orig & ~(mask << bit_start);
f819b0d4a91344c Xinliang Liu 2015-11-23  95  	tmp |= (val & mask) << bit_start;
f819b0d4a91344c Xinliang Liu 2015-11-23 @96  	writel(tmp, addr);
f819b0d4a91344c Xinliang Liu 2015-11-23  97  }
f819b0d4a91344c Xinliang Liu 2015-11-23  98  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (162132 bytes)